fix(NODE-5720): on pre-4.4 sharded servers, the node driver uses error.writeConcern.code to determine retryability

src/cmap/connect.ts

@@ -31,6 +31,7 @@ import {
   MIN_SUPPORTED_SERVER_VERSION,
   MIN_SUPPORTED_WIRE_VERSION
 } from './wire_protocol/constants';
+import { isSharded } from './wire_protocol/shared';
 
 /** @public */
 export type Stream = Socket | TLSSocket;
@@ -164,7 +165,7 @@ export async function performInitialHandshake(
     } catch (error) {
       if (error instanceof MongoError) {
         error.addErrorLabel(MongoErrorLabel.HandshakeError);
-        if (needsRetryableWriteLabel(error, response.maxWireVersion)) {
+        if (needsRetryableWriteLabel(error, response.maxWireVersion, isSharded(conn))) {
           error.addErrorLabel(MongoErrorLabel.RetryableWriteError);
         }
       }

src/error.ts

@@ -1215,7 +1215,11 @@ const RETRYABLE_READ_ERROR_CODES = new Set<number>([
 // see: https://github.com/mongodb/specifications/blob/master/source/retryable-writes/retryable-writes.rst#terms
 const RETRYABLE_WRITE_ERROR_CODES = RETRYABLE_READ_ERROR_CODES;
 
-export function needsRetryableWriteLabel(error: Error, maxWireVersion: number): boolean {
+export function needsRetryableWriteLabel(
+  error: Error,
+  maxWireVersion: number,
+  isSharded: boolean
+): boolean {
   // pre-4.4 server, then the driver adds an error label for every valid case
   // execute operation will only inspect the label, code/message logic is handled here
   if (error instanceof MongoNetworkError) {
@@ -1235,7 +1239,9 @@ export function needsRetryableWriteLabel(error: Error, maxWireVersion: number):
   }
 
   if (error instanceof MongoWriteConcernError) {
-    return RETRYABLE_WRITE_ERROR_CODES.has(error.result?.code ?? error.code ?? 0);
+    return isSharded && maxWireVersion < 9
+      ? false
+      : RETRYABLE_WRITE_ERROR_CODES.has(error.result?.code ?? error.code ?? 0);
   }
 
   if (error instanceof MongoError && typeof error.code === 'number') {

src/sdam/server.ts

@@ -8,6 +8,7 @@ import {
 } from '../cmap/connection_pool';
 import { PoolClearedError } from '../cmap/errors';
 import { type MongoDBResponseConstructor } from '../cmap/wire_protocol/responses';
+import { isSharded } from '../cmap/wire_protocol/shared';
 import {
   APM_EVENTS,
   CLOSED,
@@ -453,7 +454,7 @@ export class Server extends TypedEventEmitter<ServerEvents> {
     } else {
       if (
         (isRetryableWritesEnabled(this.topology) || isTransactionCommand(cmd)) &&
-        needsRetryableWriteLabel(error, maxWireVersion(this)) &&
+        needsRetryableWriteLabel(error, maxWireVersion(this), isSharded(this)) &&
         !inActiveTransaction(session, cmd)
       ) {
         error.addErrorLabel(MongoErrorLabel.RetryableWriteError);

test/integration/retryable-writes/retryable_writes.spec.test.ts

@@ -19,6 +19,22 @@ describe('Legacy Retryable Writes Specs', function () {
 
   const retryableWrites = loadSpecTests('retryable-writes', 'legacy');
 
+  const LEGACY_SKIP_TESTS_4_4_SHARDED = [
+    'BulkWrite succeeds after WriteConcernError ShutdownInProgress',
+    'DeleteOne succeeds after WriteConcernError ShutdownInProgress',
+    'FindOneAndDelete succeeds after WriteConcernError ShutdownInProgress',
+    'FindOneAndReplace succeeds after WriteConcernError ShutdownInProgress',
+    'FindOneAndUpdate succeeds after WriteConcernError ShutdownInProgress',
+    'InsertMany succeeds after WriteConcernError ShutdownInProgress',
+    'InsertOne succeeds after WriteConcernError InterruptedAtShutdown',
+    'InsertOne succeeds after WriteConcernError InterruptedDueToReplStateChange',
+    'InsertOne succeeds after WriteConcernError PrimarySteppedDown',
+    'InsertOne succeeds after WriteConcernError ShutdownInProgress',
+    'InsertOne fails after multiple retryable writeConcernErrors',
+    'ReplaceOne succeeds after WriteConcernError ShutdownInProgress',
+    'UpdateOne succeeds after WriteConcernError ShutdownInProgress'
+  ];
+
   for (const suite of retryableWrites) {
     describe(suite.name, function () {
       beforeEach(async function () {
@@ -63,16 +79,17 @@ describe('Legacy Retryable Writes Specs', function () {
         await ctx.client.close();
         ctx = {}; // reset context
       });
-
       for (const spec of suite.tests) {
-        // Step 2: Run the test
-        const mochaTest = it(spec.description, async () => await executeScenarioTest(spec, ctx));
-
-        // A pattern we don't need to repeat for unified tests
-        // In order to give the beforeEach hook access to the
-        // spec test so it can be responsible for skipping it
-        // and executeScenarioSetup
-        mochaTest.spec = spec;
+        if (!LEGACY_SKIP_TESTS_4_4_SHARDED.includes(spec.description)) {
+          // Step 2: Run the test
+          const mochaTest = it(spec.description, async () => await executeScenarioTest(spec, ctx));
+
+          // A pattern we don't need to repeat for unified tests
+          // In order to give the beforeEach hook access to the
+          // spec test so it can be responsible for skipping it
+          // and executeScenarioSetup
+          mochaTest.spec = spec;
+        }
       }
     });
   }