feat(NODE-3469,NODE-3615,NODE-3507): update min and max wire versions #3014
Conversation
|
Failures can be resolved moving the default mock ismaster to the 3.6 version. |
|
@durran The ticket says that this work depends on https://jira.mongodb.org/browse/NODE-3596 - which has some spec changes to pull in, are the failures related to that by any chance? |
durran
force-pushed
the
NODE-3469
branch
7 times, most recently
from
2422829
to
af72798
Compare
This reverts commit 36eaa30.
nbbeeken
added
the
Primary Review
dariakp
changed the title
nbbeeken
added
Team Review
There was a problem hiding this comment.
Just a few questions here and a suggestion. Also, since we are removing tests but not the tested codepaths, can we file a follow up ticket to clean those up? (i.e., remove anything that checks an out of bound version; in particular, perhaps we can update the ServerCapabilities to always return true for the corresponding functionalities). On that note, there's also a couple of skipped change_stream tests that still have the maxWireVersion set to 4, which should probably be bumped.
| ns: 'test.test' | ||
| } | ||
| }); | ||
| } catch (e) { | ||
| console.log('error', e); |
There was a problem hiding this comment.
do we need to keep the console logs here and in L91?
There was a problem hiding this comment.
Missed the one in L91, but I took the liberty of deleting it myself since it's the only outstanding thing here to merge
There was a problem hiding this comment.
I also filed a follow up NODE-3469 for the other clean up
|
Shouldn't this a semver-major breaking change, since the minimum wire version is increased to 6, which drops support for MongoDB3.2/3.4 |
|
Hi @matthewmayer, thanks for reaching out: this change was intentional in accordance with our MongoDB Software Lifecycle Schedules. Given the server versions 3.4 and earlier are outside of our support policy range, and have been since January 2020, we no longer test our driver against them and therefore can no longer guarantee compatibility. In the interest of avoiding undefined behavior or silent failures we opted for a thrown error to make sure users are made fully aware of the updated support. We understand that this could be an unexpected change for some users; however, given the EOL status of the platforms, we expect the real impact to be minimal. We are working on a strategy to better communicate server version support changes in the future that aligns with our configurable Versioned API feature and, of course, we are always listening to the feedback from our community. |
|
I understand it is intentional, but it seems this should have been released as library version 5.0.0 not 4.2.0 following correct semver principles to minimize possible breakage. |
Description
Updates the minimum wire version for the driver to 6 (MongoDB 3.6) and max wire version to 14 (MongoDB 5.1). Also includes NODE-3615 for bumping max wire version and NODE-3507 for updating SDAM spec tests to raise the max wire version.
What is changing?
The minimum wire version in the wire protocol has been updated to 6, so MongoDB 3.6, as well as the maximum version number to 5.1 and wire version to 14 for the upcoming 5.1 release. (instead of 5.0). Tests have been added to check the relevant constants.
Is there new documentation needed for these changes?
Perhaps the minimum server version that the driver supports is now 3.6 and not 2.6
What is the motivation for this change?
DRIVERS-1315 to deprecate support for EOL MongoDB versions is the motivation.
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>