refactor!(NODE-3427): remove md5 hashing from GridFS API #2899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
commented
Jul 9, 2021
Comment on lines
+1229
to
+1231
| const specKeys = Object.keys(specDoc) | ||
| .filter(key => key !== 'md5') | ||
| .sort(); |
There was a problem hiding this comment.
There's new spec tests that omit the md5 property for us, we should use those, but we are also behind on our GridFS sync so I defer that to later work.
nbbeeken
commented
Jul 9, 2021
| @@ -9,7 +9,7 @@ import { MongoClient } from './mongo_client'; | |||
| import { Db } from './db'; | |||
| import { Collection } from './collection'; | |||
| import { Logger } from './logger'; | |||
| import { GridFSBucket } from './gridfs-stream'; | |||
| import { GridFSBucket } from './gridfs'; | |||
There was a problem hiding this comment.
I can revert this, I figured now that its our only "gridfs" no need to name it after its implementation detail
nbbeeken
commented
Jul 9, 2021
Comment on lines
-32
to
-39
| _id: GridFSBucketWriteStream['id']; | ||
| length: GridFSBucketWriteStream['length']; | ||
| chunkSize: GridFSBucketWriteStream['chunkSizeBytes']; | ||
| md5?: string; | ||
| filename: GridFSBucketWriteStream['filename']; | ||
| contentType?: GridFSBucketWriteStream['options']['contentType']; | ||
| aliases?: GridFSBucketWriteStream['options']['aliases']; | ||
| metadata?: GridFSBucketWriteStream['options']['metadata']; |
There was a problem hiding this comment.
We just don't do this anywhere else, so consistency
dariakp
requested changes
Jul 12, 2021
dariakp
added
the
Primary Review
dariakp
reviewed
Jul 12, 2021
dariakp
approved these changes
Jul 12, 2021
dariakp
added
Team Review
dariakp
requested review from
a team,
emadum and
W-A-James
and removed request for
a team and
W-A-James
emadum
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you view the second commit forward you can get the reasonable looking diff, I first did some legacy clean up ensured the tests still worked without changes, then commiting that, made the drivers changes and fixed the test failures as a result.
NODE-3427