feat(NODE-3392): enable snapshot reads on secondaries #2897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariakp
changed the title
nbbeeken
requested changes
Jul 9, 2021
dariakp
force-pushed
the
NODE-3392/snapshot-reads-on-secondaries
branch
from
2d6c3d4
to
e89a431
Compare
…ests for snapshot-sessions
… error sessions spec tests
dariakp
force-pushed
the
NODE-3392/snapshot-reads-on-secondaries
branch
from
3ed05eb
to
73378fa
Compare
dariakp
commented
Jul 12, 2021
| @@ -86,6 +86,8 @@ export function executeOperation< | |||
| session = topology.startSession({ owner, explicit: false }); | |||
| } else if (session.hasEnded) { | |||
| return cb(new MongoDriverError('Use of expired sessions is not permitted')); | |||
| } else if (session.snapshotEnabled && !topology.capabilities.supportsSnapshotReads) { | |||
| return cb(new MongoDriverError('Snapshot reads require MongoDB 5.0 or later')); | |||
There was a problem hiding this comment.
Do we want to use a more specific error here now that they are available?
There was a problem hiding this comment.
Compat and InvalidArgument are still not available so I think leaving the DriverError in there would make sense for now.
dariakp
commented
Jul 12, 2021
| if (options.snapshot === true) { | ||
| this[kSnapshotEnabled] = true; | ||
| if (options.causalConsistency === true) { | ||
| throw new MongoDriverError( |
There was a problem hiding this comment.
Do we want to use a more specific error here now that they are available?
dariakp
commented
Jul 12, 2021
| @@ -257,6 +280,10 @@ class ClientSession extends TypedEventEmitter<ClientSessionEvents> { | |||
| * @param options - Options for the transaction | |||
| */ | |||
| startTransaction(options?: TransactionOptions): void { | |||
| if (this[kSnapshotEnabled]) { | |||
| throw new MongoDriverError('Transactions are not allowed with snapshot sessions'); | |||
There was a problem hiding this comment.
Do we want to use a more specific error here now that they are available?
dariakp
added
the
Primary Review
nbbeeken
reviewed
Jul 12, 2021
| @@ -86,6 +86,8 @@ export function executeOperation< | |||
| session = topology.startSession({ owner, explicit: false }); | |||
| } else if (session.hasEnded) { | |||
| return cb(new MongoDriverError('Use of expired sessions is not permitted')); | |||
| } else if (session.snapshotEnabled && !topology.capabilities.supportsSnapshotReads) { | |||
| return cb(new MongoDriverError('Snapshot reads require MongoDB 5.0 or later')); | |||
There was a problem hiding this comment.
Compat and InvalidArgument are still not available so I think leaving the DriverError in there would make sense for now.
nbbeeken
approved these changes
Jul 12, 2021
nbbeeken
removed
the
Primary Review
emadum
approved these changes
Jul 12, 2021
nbbeeken
changed the title
ljhaywar
pushed a commit
that referenced
this pull request
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A base implementation of snapshot sessions per latest spec (NODE-3392, NODE-3393 and NODE-3394).
NOTE: Some spec tests are skipped due to test runner issues with session setup.