fix(NODE-6469): pool is cleared before connection checkin on error #4296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
4 tasks
baileympearson
force-pushed
the
spec-fest-1
branch
from
c45ef7c to
94a7090
Compare
baileympearson
force-pushed
the
spec-fest-1
branch
from
43e5f87 to
b527e5b
Compare
baileympearson
changed the title
aditi-khare-mongoDB
added
the
Primary Review
nbbeeken
reviewed
Nov 19, 2024
|
NODE-5230 was resolved in this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Incorporate test changes from mongodb/specifications#1690.
Additionally, we now always clear the pool after failing to establish a connection before any other error handling logic.
Is there new documentation needed for these changes?
What is the motivation for this change?
Release Highlight
ConnectionClosedEvents always follow PoolClearedEvents
When Connection Monitoring and Pooling events are listened for,
ConnectionClosedEvents are now always emitted afterPoolClearEvents.Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript