-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NODE-3852,NODE-3854,NODE-3856): Misc typescript fixes for 4.3.1 #3102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Neal Beeken <[email protected]>
baileympearson
changed the title
WIP fix(NODE-3856): Misc typescript fixes for 4.3.1
fix(NODE-3856): Misc typescript fixes for 4.3.1
Jan 12, 2022
baileympearson
commented
Jan 12, 2022
dariakp
changed the title
fix(NODE-3856): Misc typescript fixes for 4.3.1
fix(NODE-3852,NODE-3854,NODE-3856): Misc typescript fixes for 4.3.1
Jan 12, 2022
baileympearson
commented
Jan 12, 2022
dariakp
added
the
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
label
Jan 13, 2022
baileympearson
commented
Jan 13, 2022
dariakp
requested changes
Jan 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small thing from me, to make this easier to follow (and possibly amend later)
8 tasks
5 tasks
dariakp
added
Team Review
Needs review from team
and removed
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
labels
Jan 14, 2022
nbbeeken
approved these changes
Jan 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
dariakp
approved these changes
Jan 14, 2022
Closed
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes three Typescript fixes / improvements.
What is changing?
findX
operationsfindOneAnd<op>
to include the_id
field. The behavior of these functions is now aligned with the generalfindX
methodsIs there new documentation needed for these changes?
Probably. I think we should document exactly what is and is not supported somewhere once we flesh out exactly what we're supporting and we're not supporting.
Double check the following
npm run check:lint
script<type>(NODE-xxxx)<!>: <description>