fix: "willRetryWrites"

mongodb · Mar 14, 2022 · ff5b12e · ff5b12e
1 parent ffba0f4
commit ff5b12e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/operations/execute_operation.ts b/src/operations/execute_operation.ts
@@ -249,7 +249,7 @@ function executeWithServerSelection<TResult>(
 
       if ((hasReadAspect && willRetryRead) || (hasWriteAspect && willRetryWrite)) {
         if (hasWriteAspect && willRetryWrite) {
-          operation.options.willRetryWrite = true;
+          operation.options.willRetryWrites = true;
           session.incrementTransactionNumber();
         }
 

diff --git a/src/operations/operation.ts b/src/operations/operation.ts
@@ -57,7 +57,7 @@ export abstract class AbstractOperation<TResult = any> {
   bsonOptions?: BSONSerializeOptions;
 
   // TODO: Each operation defines its own options, there should be better typing here
-  options: Document;
+  options: OperationOptions;
 
   [kSession]: ClientSession | undefined;
 

diff --git a/src/sessions.ts b/src/sessions.ts
@@ -964,10 +964,10 @@ export function applySession(
   command.lsid = serverSession.id;
 
   // first apply non-transaction-specific sessions data
-  const inTransaction = session.inTransaction() || isTransactionCommand(command);
-  const isRetryableWrite = options?.willRetryWrite || false;
+  const inTransaction = session.inTransaction() ?? isTransactionCommand(command);
+  const isRetryableWrite = options.willRetryWrites ?? false;
 
-  if (serverSession.txnNumber && (isRetryableWrite || inTransaction)) {
+  if (isRetryableWrite || inTransaction) {
     command.txnNumber = Long.fromNumber(serverSession.txnNumber);
   }