test(NODE-6317): fix test assertions and naming (#4217)

mongodb · Sep 4, 2024 · 65e0e15 · 65e0e15
1 parent f53e9d9
commit 65e0e15
Showing 1 changed file with 24 additions and 15 deletions.
diff --git a/test/integration/server-discovery-and-monitoring/server_discover_and_monitoring.test.ts b/test/integration/server-discovery-and-monitoring/server_discover_and_monitoring.test.ts
@@ -83,23 +83,20 @@ describe('Monitoring rtt tests', function () {
           await promise;
         });
 
-        it(
-          'heartbeat duration is not incorrectly reported as zero on ServerHeartbeatSucceededEvents',
-          {
-            metadata: {
-              requires: { topology: '!load-balanced' }
-            },
-            test: async function () {
-              for (const durations of Object.values(heartbeatDurations)) {
-                const relevantDurations = durations.slice(IGNORE_SIZE);
-                expect(relevantDurations).to.have.length.gt(0);
-                const averageDuration =
-                  relevantDurations.reduce((acc, x) => acc + x) / relevantDurations.length;
-                expect(averageDuration).to.be.gt(DELAY_MS);
-              }
+        it('ServerHeartbeatSucceededEvent.duration is greater than or equal to the actual rtt', {
+          metadata: {
+            requires: { topology: '!load-balanced' }
+          },
+          test: async function () {
+            for (const durations of Object.values(heartbeatDurations)) {
+              const relevantDurations = durations.slice(IGNORE_SIZE);
+              expect(relevantDurations).to.have.length.gt(0);
+              const averageDuration =
+                relevantDurations.reduce((acc, x) => acc + x) / relevantDurations.length;
+              expect(averageDuration).to.be.gte(DELAY_MS);
             }
           }
-        );
+        });
 
         it('ServerDescription.roundTripTime is not incorrectly reported as zero', {
           metadata: {
@@ -114,6 +111,18 @@ describe('Monitoring rtt tests', function () {
             }
           }
         });
+
+        it('ServerDescription.roundTripTime is greater than or equal to the actual rtt', {
+          metadata: {
+            requires: { topology: '!load-balanced' }
+          },
+          test: async function () {
+            for (const server of Object.keys(heartbeatDurations)) {
+              const rtt = client.topology.description.servers.get(server).roundTripTime;
+              expect(rtt).to.be.gte(DELAY_MS);
+            }
+          }
+        });
       });
     });
   }