CLOUDP-240677 Update SDK update process to handle minor versions and create jiras #2825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmenezes
changed the title
|
this works and verified, created #2826 and https://jira.mongodb.org/browse/CLOUDP-241394 |
fmenezes
commented
Apr 5, 2024
| - name: Verify Changed files | ||
| uses: tj-actions/verify-changed-files@1e517a7f5663673148ceb7c09c1900e5af48e7a1 | ||
| id: verify-changed-files | ||
| with: | ||
| files: | | ||
| ./internal/**/* | ||
| go.mod |
There was a problem hiding this comment.
this is the actual change to make it work for minor and patch versions
fmenezes
commented
Apr 5, 2024
| @@ -8,6 +8,8 @@ updates: | |||
| open-pull-requests-limit: 20 | |||
| reviewers: | |||
| - "mongodb/mongocli" | |||
| ignore: | |||
| - dependency-name: "go.mongodb.org/atlas-sdk/*" | |||
There was a problem hiding this comment.
ignoring on dependabot
There was a problem hiding this comment.
Actualy I'm not sure that we should do this. Do we have other job covering minor updates?
wtrocki
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Update SDK update process to handle minor versions and create jiras
Jira ticket: CLOUDP-240677
Closes #[issue number]
Checklist
make fmtand formatted my codeFurther comments