task: remove the atlas folder for commands #2802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blva
reviewed
Mar 25, 2024
| @@ -24,7 +24,7 @@ import ( | |||
|
|
|||
| "github.com/AlecAivazis/survey/v2" | |||
| "github.com/AlecAivazis/survey/v2/core" | |||
| "github.com/mongodb/mongodb-atlas-cli/atlascli/internal/cli/root/atlas" | |||
| "github.com/mongodb/mongodb-atlas-cli/atlascli/internal/cli/root" | |||
There was a problem hiding this comment.
won't this affect go:generate mockgen references as well?
both destination=. and package reference, ok if we want to do a follow-up PR but mock generation may be broken meanwhile so may be worth to get next PR ready
There was a problem hiding this comment.
won't this affect go:generate mockgen references as well?
No, I fixed the mocks and ran make gen-mock after my commit to confirm there are no changes as expected
blva
approved these changes
Mar 25, 2024
jeroenvervaeke
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deep nesting makes certain commands like
go fmtorgo testslower now that everything is atlas we can simplify some of our folder structure a littleFlatten the folder structure since everything is atlas now so no need for a
cli/atlasfolder to differentiate the from the old ops manager/cloud manager commandsThis change is only file moves and import fixes, no other changes