Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task: remove config.BinName #2801

Merged
merged 1 commit into from
Mar 25, 2024
Merged

task: remove config.BinName #2801

merged 1 commit into from
Mar 25, 2024

Conversation

gssbzn
Copy link
Collaborator

@gssbzn gssbzn commented Mar 25, 2024

remove config.BinName since it's always atlas and the value can now be inline

@gssbzn gssbzn requested a review from a team March 25, 2024 10:43
blva
blva approved these changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@blva blva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@gssbzn gssbzn merged commit 9fbcd2c into master Mar 25, 2024
18 checks passed
@gssbzn gssbzn deleted the remove-configBin branch March 25, 2024 11:21
@fmenezes fmenezes mentioned this pull request Apr 5, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blva blva blva approved these changes

@jeroenvervaeke jeroenvervaeke jeroenvervaeke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gssbzn @jeroenvervaeke @blva