Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: don't delete my profile when testing #2795

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Conversation

gssbzn
Copy link
Collaborator

@gssbzn gssbzn commented Mar 21, 2024

There were a couple of bugs on various tests depending on global state of the cli config and leaking into the actual config file causing unexpected deletions

Fixing by not depending on the global state

@gssbzn gssbzn requested a review from a team March 21, 2024 18:40
Copy link
Collaborator

@colm-quinn colm-quinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for looking into the config issues

@gssbzn gssbzn merged commit 64d88c4 into master Mar 22, 2024
17 checks passed
@gssbzn gssbzn deleted the fix-profile-testing branch March 22, 2024 09:50
@fmenezes fmenezes mentioned this pull request Apr 5, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants