Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix go.mod file to avoid darwin issues #2785

Closed
wants to merge 1 commit into from
Closed

Fix go.mod file to avoid darwin issues #2785

wants to merge 1 commit into from

Conversation

blva
Copy link
Collaborator

@blva blva commented Mar 19, 2024

Proposed changes

Minor fix to avoid issues with updating golang. Following suggestion in golang/go#65568

Before

❯ make deps
go: downloading go1.22 (darwin/arm64)
go: download go1.22 for darwin/arm64: toolchain not available
==> Installing go.mod dependencies...
go mod download
go: downloading go1.22 (darwin/arm64)
go: download go1.22 for darwin/arm64: toolchain not available
make: *** [deps] Error 1

After

go: downloading go1.22.0 (darwin/arm64)
==> Installing go.mod dependencies...
go mod download
go mod tidy
go: downloading github.com/onsi/ginkgo/v2 v2.15.0
go: downloading github.com/onsi/gomega v1.31.1
go: downloading go.uber.org/goleak v1.3.0
go: downloading go.opentelemetry.io/otel/sdk v1.21.0
go: downloading github.com/evanphx/json-patch v5.6.0+incompatible

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@blva blva marked this pull request as ready for review March 19, 2024 14:32
@blva blva requested a review from a team March 19, 2024 14:32
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated of #2779

@blva blva closed this Mar 19, 2024
@gssbzn gssbzn deleted the fix-go-mod branch August 6, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants