Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-222791: expose "include total" on paginated commands - Part 2 #2754

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

andreaangiolillo
Copy link
Collaborator

Proposed changes

Jira ticket: CLOUDP-222791

This is the last PR where we are introducing the omitCount for all the AtlasCLI list commands.
Follow-up PR of #2749

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@andreaangiolillo andreaangiolillo marked this pull request as ready for review March 12, 2024 09:17
@andreaangiolillo andreaangiolillo requested review from a team as code owners March 12, 2024 09:17
@andreaangiolillo andreaangiolillo requested a review from a team March 12, 2024 09:17
@andreaangiolillo andreaangiolillo changed the title CLOUDP-222791: CLOUDP-222791: expose "include total" on paginated commands - Part 2 CLOUDP-222791: expose "include total" on paginated commands - Part 2 Mar 12, 2024
@@ -47,7 +47,7 @@ func (opts *ListOpts) initStore(ctx context.Context) func() error {
}

func (opts *ListOpts) Run() error {
r, err := opts.store.ProjectTeams(opts.ConfigProjectID())
r, err := opts.store.ProjectTeams(opts.ConfigProjectID(), opts.NewAtlasListOptions())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks for the bug fix

@andreaangiolillo andreaangiolillo merged commit 45109b4 into master Mar 12, 2024
30 checks passed
@andreaangiolillo andreaangiolillo deleted the CLOUDP-222791_2 branch March 12, 2024 10:25
@fmenezes fmenezes mentioned this pull request Apr 5, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants