Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-236398: update new version message to remove full stop #2729

Merged
merged 2 commits into from
Mar 7, 2024
+5 −5
Merged

CLOUDP-236398: update new version message to remove full stop #2729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a972bbd
CLOUDP-236398: update new version message to remove full stop
andreaangiolillo Mar 7, 2024
c2c6b17
fixes
andreaangiolillo Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions internal/cli/root/atlas/builder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,16 +344,16 @@ func (n *Notifier) notifyIfApplicable(isHb bool) error {

var upgradeInstructions string
if isHb {
upgradeInstructions = `To upgrade, run "brew update && brew upgrade mongodb-atlas-cli".`
upgradeInstructions = `To upgrade, run "brew update && brew upgrade mongodb-atlas-cli"`
} else {
upgradeInstructions = "To upgrade, see: https://dochub.mongodb.org/core/install-atlas-cli."
upgradeInstructions = "To upgrade, see: https://dochub.mongodb.org/core/install-atlas-cli"
}

newVersionTemplate := `
A new version of atlascli is available '%s'!
%s
To disable this alert, run "%s config set skip_update_check true".
To disable this alert, run "%s config set skip_update_check true"
`
_, err = fmt.Fprintf(n.writer, newVersionTemplate, release.Version, upgradeInstructions, config.BinName())
return err
Expand Down
4 changes: 2 additions & 2 deletions internal/cli/root/atlas/builder_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,9 @@ func TestOutputOpts_notifyIfApplicable(t *testing.T) {
if tt.expectNewVersion {
want = fmt.Sprintf(`
A new version of atlascli is available '%v'!
To upgrade, see: https://dochub.mongodb.org/core/install-atlas-cli.
To upgrade, see: https://dochub.mongodb.org/core/install-atlas-cli
To disable this alert, run "%s config set skip_update_check true".
To disable this alert, run "%s config set skip_update_check true"
`, v, config.BinName())
}

Expand Down