Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-234532: fix atlas customDbRoles update command #2687

Merged
merged 4 commits into from
Mar 1, 2024
Merged

Conversation

tibulca
Copy link
Collaborator

@tibulca tibulca commented Feb 29, 2024

Proposed changes

fix atlas customDbRoles update command
Jira ticket: CLOUDP-234532

Testing

  • atlas_iam_e2e
    [2024/03/01 08:58:55.840] --- PASS: TestAtlasCustomDbRoles (2.69s)
    [2024/03/01 08:58:55.840] --- PASS: TestAtlasCustomDbRoles/Create (0.17s)
    [2024/03/01 08:58:55.840] --- PASS: TestAtlasCustomDbRoles/Describe (0.11s)
    [2024/03/01 08:58:55.840] --- PASS: TestAtlasCustomDbRoles/Update (0.18s)
    [2024/03/01 08:58:55.840] --- PASS: TestAtlasCustomDbRoles/List (0.10s)
    [2024/03/01 08:58:55.840] --- PASS: TestAtlasCustomDbRoles/Delete (0.13s)

@tibulca tibulca requested a review from a team February 29, 2024 18:08
gssbzn
gssbzn previously approved these changes Feb 29, 2024
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we write some test to catch this next time?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tibulca tibulca requested a review from gssbzn March 1, 2024 10:16
@tibulca tibulca merged commit 63207dd into master Mar 1, 2024
17 checks passed
@tibulca tibulca deleted the CLOUDP-234532 branch March 1, 2024 10:40
@fmenezes fmenezes mentioned this pull request Apr 5, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants