Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-226171: handle safely pointers of slices in the output templates #2569

Merged
merged 3 commits into from
Jan 26, 2024
Merged

CLOUDP-226171: handle safely pointers of slices in the output templates #2569

merged 3 commits into from
Jan 26, 2024

Conversation

tibulca
Copy link
Collaborator

@tibulca tibulca commented Jan 26, 2024

Proposed changes

handle safely pointers of slices in the output templates

Jira ticket: CLOUDP-226171

@tibulca tibulca requested a review from a team January 26, 2024 17:10
gssbzn
gssbzn reviewed Jan 26, 2024
View reviewed changes
internal/templatewriter/templatewriter_test.go Outdated
template string
data interface{}
expected string
expectedErr bool
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check

mongodb-atlas-cli/internal/cli/opsmanager/clusters/describe_test.go

Line 75 in 0ca38a9

wantErr require.ErrorAssertionFunc

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thanks

@tibulca tibulca merged commit cbea179 into master Jan 26, 2024
18 checks passed
@tibulca tibulca deleted the CLOUDP-226171 branch January 26, 2024 18:12
wtrocki
wtrocki reviewed Jan 26, 2024
View reviewed changes
Copy link
Member

@wtrocki wtrocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtrocki wtrocki wtrocki left review comments

@gssbzn gssbzn gssbzn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tibulca @gssbzn @wtrocki