Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-172196: migrate ListCloudProviderRegions #1950

Merged
merged 2 commits into from
May 30, 2023
Merged

CLOUDP-172196: migrate ListCloudProviderRegions #1950

merged 2 commits into from
May 30, 2023

Conversation

matt-condon
Copy link
Collaborator

Proposed changes

SDKv2 Migration of ListCloudProviderRegions

Jira ticket: CLOUDP-172196

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

@matt-condon matt-condon requested a review from a team May 18, 2023 17:47
@wtrocki
Copy link
Member

wtrocki commented May 23, 2023

@swattyT @wtrocki Check if that works

@wtrocki
Copy link
Member

wtrocki commented May 26, 2023 •
edited
Loading

We did provide fix in the new SDK that needs to be added here.
Rebase is needed.

@matt-condon matt-condon force-pushed the sdkMigration/cloudProviderRegions branch from b48abab to 1589ca6 Compare May 29, 2023 14:37
wtrocki
wtrocki approved these changes May 29, 2023
View reviewed changes
Copy link
Member

@wtrocki wtrocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested locally

@matt-condon matt-condon merged commit b231c6a into master May 30, 2023
@matt-condon matt-condon deleted the sdkMigration/cloudProviderRegions branch May 30, 2023 08:50
matt-condon added a commit that referenced this pull request May 31, 2023
@matt-condon
CLOUDP-172196: migrate ListCloudProviderRegions (#1950)
bab6e8e
matt-condon added a commit that referenced this pull request May 31, 2023
@matt-condon
CLOUDP-172196: migrate ListCloudProviderRegions (#1950)
99e993f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtrocki wtrocki wtrocki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matt-condon @wtrocki