Skip to content

Commit

Permalink
CLOUDP-236398: update new version message to remove full stop (#2729)
Browse files Browse the repository at this point in the history
  • Loading branch information
andreaangiolillo authored Mar 7, 2024
1 parent 9acf939 commit f0edfd3
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions internal/cli/root/atlas/builder.go
Original file line number Diff line number Diff line change
Expand Up @@ -344,16 +344,16 @@ func (n *Notifier) notifyIfApplicable(isHb bool) error {

var upgradeInstructions string
if isHb {
upgradeInstructions = `To upgrade, run "brew update && brew upgrade mongodb-atlas-cli".`
upgradeInstructions = `To upgrade, run "brew update && brew upgrade mongodb-atlas-cli"`
} else {
upgradeInstructions = "To upgrade, see: https://dochub.mongodb.org/core/install-atlas-cli."
upgradeInstructions = "To upgrade, see: https://dochub.mongodb.org/core/install-atlas-cli"
}

newVersionTemplate := `
A new version of atlascli is available '%s'!
%s
To disable this alert, run "%s config set skip_update_check true".
To disable this alert, run "%s config set skip_update_check true"
`
_, err = fmt.Fprintf(n.writer, newVersionTemplate, release.Version, upgradeInstructions, config.BinName())
return err
Expand Down
4 changes: 2 additions & 2 deletions internal/cli/root/atlas/builder_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,9 @@ func TestOutputOpts_notifyIfApplicable(t *testing.T) {
if tt.expectNewVersion {
want = fmt.Sprintf(`
A new version of atlascli is available '%v'!
To upgrade, see: https://dochub.mongodb.org/core/install-atlas-cli.
To upgrade, see: https://dochub.mongodb.org/core/install-atlas-cli
To disable this alert, run "%s config set skip_update_check true".
To disable this alert, run "%s config set skip_update_check true"
`, v, config.BinName())
}

Expand Down

0 comments on commit f0edfd3

Please sign in to comment.