CLOUDP-238518: Windows binaries are not signed (#2781)

mongodb · Mar 19, 2024 · 861bd1b · 861bd1b
1 parent b6d1f93
commit 861bd1b
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/build/ci/release.yml b/build/ci/release.yml
@@ -264,10 +264,11 @@ tasks:
           local_files_include_filter:
             - src/github.com/mongodb/mongodb-atlas-cli/bin/*.exe
             - src/github.com/mongodb/mongodb-atlas-cli/dist/*.msi
-          remote_file: ${project}/dist/${revision}_${created_at}/
+          remote_file: ${project}/dist/${revision}_${created_at}/unsigned_
           bucket: mongodb-mongocli-build
           permissions: public-read
           content_type: ${content_type|application/octet-stream}
+          display_name: unsigned
   - name: package_goreleaser
     tags: ["packaging"]
     depends_on:

diff --git a/build/package/download-win-binaries.sh b/build/package/download-win-binaries.sh
@@ -28,10 +28,13 @@ fi
 PACKAGE_NAME="mongodb-atlas-cli_${VERSION_NAME}_windows_x86_64.msi"
 BINARY_NAME="atlas.exe"
 
+PACKAGE_URL=https://${BUCKET}.s3.amazonaws.com/${project}/dist/${revision}_${created_at}/unsigned_${PACKAGE_NAME}
+BINARY_URL=https://${BUCKET}.s3.amazonaws.com/${project}/dist/${revision}_${created_at}/unsigned_${BINARY_NAME}
+
 pushd bin
 
-echo "downloading https://${BUCKET}.s3.amazonaws.com/${project}/dist/${revision}_${created_at}/${PACKAGE_NAME} into $PWD"
-curl "https://${BUCKET}.s3.amazonaws.com/${project}/dist/${revision}_${created_at}/${PACKAGE_NAME}" --output "${PACKAGE_NAME}"
+echo "downloading $PACKAGE_URL into $PWD/$PACKAGE_NAME"
+curl "$PACKAGE_URL" --output "${PACKAGE_NAME}"
 
-echo "downloading https://${BUCKET}.s3.amazonaws.com/${project}/dist/${revision}_${created_at}/${BINARY_NAME} into $PWD"
-curl "https://${BUCKET}.s3.amazonaws.com/${project}/dist/${revision}_${created_at}/${BINARY_NAME}" --output "${BINARY_NAME}"
+echo "downloading $BINARY_URL into $PWD/$BINARY_NAME"
+curl "$BINARY_URL" --output "${BINARY_NAME}"
diff --git a/build/package/windows_notarize.sh b/build/package/windows_notarize.sh
@@ -16,7 +16,7 @@
 
 set -Eeou pipefail
 
-EXE_FILE="dist/windows_windows_amd64_v1/bin/atlas.exe"
+EXE_FILE="bin/atlas.exe"
 MSI_FILE="bin/mongodb-atlas-cli_${VERSION}_windows_x86_64.msi"
 
 if [[ -f "$EXE_FILE" && -f "$MSI_FILE" ]]; then