chore: Respond to PR feedback

mongodb · Mar 20, 2024 · 488dbf4 · 488dbf4
1 parent ef5d5bf
commit 488dbf4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 14 deletions.
diff --git a/internal/cli/atlas/streams/instance/download.go b/internal/cli/atlas/streams/instance/download.go
@@ -51,7 +51,7 @@ func (opts *DownloadOpts) initStore(ctx context.Context) func() error {
 
 func (opts *DownloadOpts) Run() error {
 	params := atlasv2.DownloadStreamTenantAuditLogsApiParams{
-		GroupId:    opts.ProjectID,
+		GroupId:    opts.ConfigProjectID(),
 		TenantName: opts.tenantName,
 	}
 

diff --git a/internal/cli/atlas/streams/instance/download_test.go b/internal/cli/atlas/streams/instance/download_test.go
@@ -16,7 +16,7 @@ package instance
 
 import (
 	"io"
-	"os"
+	"strings"
 	"testing"
 
 	"github.com/golang/mock/gomock"
@@ -37,19 +37,8 @@ func TestDownloadOpts_Run(t *testing.T) {
 	const projectID = "download-project-id"
 	const tenantName = "streams-tenant"
 
-	file, err := os.CreateTemp("", "")
-	if err != nil {
-		require.NoError(t, err)
-	}
-	filename := file.Name()
-	defer os.Remove(filename)
-	_, _ = file.WriteString(contents)
-	_ = file.Close()
-
-	expected, _ := os.Open(filename)
-	defer expected.Close()
-
 	fs := afero.NewMemMapFs()
+
 	downloadOpts := &DownloadOpts{
 		store: mockStore,
 		DownloaderOpts: cli.DownloaderOpts{
@@ -67,6 +56,8 @@ func TestDownloadOpts_Run(t *testing.T) {
 	downloadParams.GroupId = projectID
 	downloadParams.TenantName = tenantName
 
+	expected := io.NopCloser(strings.NewReader(contents))
+
 	mockStore.
 		EXPECT().
 		DownloadAuditLog(downloadParams).