PYTHON-2328 Reset the connection pool in Topology.on_change #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change resolves a race in test_pool_reset and avoids the need to aquire the Topology lock a second time when processing a failed heartbeat.
prashantmital
approved these changes
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PYTHON-2304 Ensure _RttMonitor closes socket
This PR fixes the two flaky tests described in PYTHON-2328 and PYTHON-2304.
For PYTHON-2328 we reset the connection pool in Topology.on_change. This not only resolves the race in test_pool_reset but also avoids the need to acquire the Topology lock a second time when processing a failed heartbeat.