PYTHON-3668 Use polling SDAM mode on FaaS and add sdamMode=auto/stream/poll #1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd say let's wait for consensus on mongodb/specifications#1452, and defer this to 4.6. |
NoahStapp
approved these changes
Aug 22, 2023
pymongo/common.py
Outdated
| @@ -669,6 +672,16 @@ def validate_datetime_conversion(option: Any, value: Any) -> Optional[DatetimeCo | |||
| raise TypeError(f"{option} must be a str or int representing DatetimeConversion") | |||
|
|
|||
|
|
|||
| def validate_sdam_mode(option: Any, value: Any) -> str: | |||
There was a problem hiding this comment.
Is value annotated as Any for consistency with other validation methods? We're explicitly checking that value is one of three specific strings, which suggests it should be annotated as such.
4 tasks
blink1073
reviewed
Oct 6, 2023
|
I opened https://jira.mongodb.org/browse/PYTHON-3994 to track the docs failure. |
blink1073
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PYTHON-3668
The implementation of mongodb/specifications#1452.