Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PYTHON-694 Test mod_wsgi sub interpreters #1327

Merged
merged 11 commits into from
Jul 27, 2023

Conversation

ShaneHarvey
Copy link
Member

@ShaneHarvey ShaneHarvey commented Jul 25, 2023

https://jira.mongodb.org/browse/PYTHON-694

Tasks:

  • Tests mod_wsgi sub interpreters.
  • Tests mod_wsgi embedded mode.
  • Test decoding all BSON types.
  • Test encoding all BSON types.
  • Test that decoded types created from C are valid in Python, ie assert isinstance(doc["regex"], Regex).
  • Update Readme to document why multiple URLs are used.
  • Fix mypy error:
      test/mod_wsgi_test/mod_wsgi_test.py:71: error: Cannot find implementation or
library stub for module named "mod_wsgi"  [import]
        from mod_wsgi import version as mod_wsgi_version

References:

@ShaneHarvey ShaneHarvey marked this pull request as ready for review July 26, 2023 22:42
@ShaneHarvey
Copy link
Member Author

Somewhat confusingly, these tests pass even with DatetimeMS which should be expected to fail due to the bug described in https://jira.mongodb.org/browse/PYTHON-3847. I'm a bit perplexed here but we can merge this work regardless. Perhaps Python or mod_wsgi was changed to make Python classes work between sub interpreters?

@ShaneHarvey ShaneHarvey requested a review from blink1073 July 26, 2023 23:00
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@ShaneHarvey ShaneHarvey merged commit eed4a55 into mongodb:master Jul 27, 2023
@ShaneHarvey ShaneHarvey deleted the PYTHON-694 branch July 27, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants