Do not retry a read operation when in a transaction #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a regression introduced in 4.4.0 in scope of JAVA-4034, and was undetected due to the lack of a specification test for the required behavior. JAVA-4684
jyemin
commented
Jul 22, 2022
| @@ -437,21 +437,12 @@ static boolean canRetryWrite(final ServerDescription serverDescription, final Co | |||
| return true; | |||
| } | |||
|
|
|||
| static boolean isRetryableRead(final boolean retryReads, final ServerDescription serverDescription, | |||
There was a problem hiding this comment.
In JAVA-4034, use of this method was removed with the addition of the RetryState class, but that caused us to lost the check for sessionContext.hasActiveTransaction(). Since the RetryState class already has the check for whether retryReads is enabled, I chose to just remove this unused method and move that check into canRetryRead below.
rozza
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced in 4.4.0 in scope of JAVA-4034, and
was undetected due to the lack of a specification test for the
required behavior.
JAVA-4684