Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor internal APIs to avoid requiring duplicate data in method/constructor params #871

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

stIncMale
Copy link
Member

This is a follow-up for #869, Since this PR contains only refactoring, there is no need to port it to older versions.

JAVA-4471

@stIncMale stIncMale requested a review from jyemin February 7, 2022 16:23
@stIncMale stIncMale self-assigned this Feb 7, 2022
* <a href="https://github.com/mongodb/specifications/blob/master/source/server-discovery-and-monitoring/server-discovery-and-monitoring.rst">
* Server Discovery And Monitoring</a> specification.
*/
void onChange(ServerDescriptionChangedEvent event);
Copy link
Member Author

@stIncMale stIncMale Feb 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method replaces ServerDescriptionChangedListener, which is no ​more.

Copy link
Contributor

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've always found that internal listener class to be confusing. Glad to see it gone.

LGTM

@stIncMale stIncMale merged commit ffe64ec into mongodb:master Feb 7, 2022
@stIncMale stIncMale deleted the JAVA-4471_part2 branch February 7, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants