Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix manifest import-package imports #779

Merged
merged 1 commit into from
Sep 6, 2021
Merged

Conversation

rozza
Copy link
Member

@rozza rozza commented Sep 3, 2021

Refs: #771 Using the suggested method by @stbischof

Fixes imports in mongo-scala-bson, mongodb-driver-sync, mongodb-driver-reactivestreams, mongodb-driver-core.

JAVA-4274

Copy link
Contributor

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you post a comment that shows the diff between the generated old and new manifests?

driver-core/build.gradle Show resolved Hide resolved
@rozza
Copy link
Member Author

rozza commented Sep 3, 2021

Added imports to import packages:

  • mongodb-driver-core

    • javax.annotation
    • javax.annotation.meta
    • javax.security.auth
    • javax.security.auth.kerberos
    • javax.security.auth.login
  • mongodb-driver-sync:

    • javax.naming
    • javax.naming.spi
    • javax.net.ssl
  • mongodb-driver-reactivestreams:

    • javax.net.ssl
    • org.reactivestreams
  • mongodb-driver-scala:

    • org.mongodb.scala.bson
    • org.mongodb.scala.bson.codecs
    • org.mongodb.scala.bson.collection.immutable
    • org.reactivestreams

@jyemin
Copy link
Contributor

jyemin commented Sep 3, 2021

Huh, do you know why these missing imports didn't also break OSGi apps?

@jyemin jyemin self-requested a review September 3, 2021 17:44
Copy link
Contributor

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stbischof
Copy link

It does break my app. But the one that use OSGi know how to quick fix this. E.g. fragment hosts or other bad tricks.

@rozza rozza merged commit 23921b3 into mongodb:master Sep 6, 2021
@rozza rozza deleted the JAVA-4274 branch September 6, 2021 09:54
rozza added a commit to rozza/mongo-java-driver that referenced this pull request Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants