Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support aggregation with $merge as a string #768

Merged
merged 1 commit into from
Jul 29, 2021
Merged

Support aggregation with $merge as a string #768

merged 1 commit into from
Jul 29, 2021

Conversation

jyemin
Copy link
Collaborator

@jyemin jyemin commented Jul 27, 2021

@jyemin jyemin self-assigned this Jul 27, 2021
@jyemin jyemin requested a review from rozza July 27, 2021 18:44
rozza
rozza approved these changes Jul 29, 2021
View reviewed changes
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Shame there is still lots of logic duplicated and mixed up in the Publisher / Iterable implementations.

@jyemin jyemin merged commit 7d1eabb into mongodb:master Jul 29, 2021
@jyemin jyemin deleted the j4258 branch July 29, 2021 12:38
jyemin added a commit that referenced this pull request Jul 29, 2021
@jyemin
Support aggregation with $merge as a string (#768)
05fdd7e 
JAVA-4258
jyemin added a commit that referenced this pull request Jul 29, 2021
@jyemin
Support aggregation with $merge as a string (#768)
2a32ac3 
JAVA-4258
@sync-by-unito sync-by-unito bot mentioned this pull request Aug 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rozza rozza rozza approved these changes

Assignees

@jyemin jyemin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jyemin @rozza