Revert making BsonEncoder / BsonDecoder internal #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made BsonEncoder / Decoder internal as part of the JsonElement support, however, this reduces the flexibility of the API and that change should be reverted JAVA-5623
|
In 7e4661c I made the |
nhachicha
reviewed
Sep 24, 2024
bson-kotlinx/src/main/kotlin/org/bson/codecs/kotlinx/BsonDecoder.kt
Outdated
Show resolved
Hide resolved
nhachicha
approved these changes
Sep 24, 2024
| import org.bson.codecs.kotlinx.JsonBsonPolymorphicDecoder | ||
|
|
||
| @ExperimentalSerializationApi | ||
| internal object BsonEncoderDecoderUtils { |
There was a problem hiding this comment.
Nitpicking 🤓 this could be named BsonCodecUtils since by definition a codec uses an Encoder and Decoder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made BsonEncoder / Decoder internal as part of the JsonElement support, however, this reduces the flexibility of the API and that change should be reverted
JAVA-5623