Improved Bulk Write API #1509
Draft
Improved Bulk Write API #1509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAVA-5527 DRIVERS-2975 --------- Co-authored-by: Viacheslav Babanin <[email protected]>
…1486) JAVA-5528, JAVA-5609 --------- Co-authored-by: Viacheslav Babanin <[email protected]>
stIncMale
commented
Oct 3, 2024
| * | ||
| * @return The top-level error. {@linkplain Optional#isPresent() Present} only if a top-level error occurred. | ||
| */ | ||
| public Optional<MongoException> getError() { |
There was a problem hiding this comment.
BULK-TODO: It all of a sudden turned out that the spec never meant to prescribe how to represent the top-level error, and we are allowed to express the top-level error as the cause of ClientBulkWriteException. Currently, I like that approach much more, and I think we should change the API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following test runners execute the unified and prose tests added in this PR:
com.mongodb.client.unified.VersionedApiTestcom.mongodb.client.unified.UnifiedTransactionsTestcom.mongodb.client.unified.ServerSelectionLoggingTestcom.mongodb.client.unified.UnifiedRetryableWritesTestcom.mongodb.client.unified.CommandMonitoringTestcom.mongodb.client.unified.UnifiedCrudTestcom.mongodb.client.CrudProseTestJAVA-4586: