Use InetAddressResolverProvider and add tests
#1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a backport of 9a02f81 from `master` to `5.0.x` JAVA-5390
jyemin
approved these changes
Mar 28, 2024
| * | ||
| * <p>If set, it will be used to look up the {@link java.net.InetAddress} for each host, via | ||
| * {@link InetAddressResolver#lookupByName(String)}. Otherwise, {@link java.net.InetAddress#getAllByName(String)} will be used. | ||
| * Gets the explicitly set {@link InetAddressResolver} to use for looking up the {@link java.net.InetAddress} instances for each host. |
There was a problem hiding this comment.
Just FYI, we generally don't update Javadoc in patch releases, because we don't republish the Javadoc for patch releases. But it doesn't do any harm, so it's ok to leave this.
There was a problem hiding this comment.
Right, thanks! It's still better to have the source code consistent with the published API documentation, so I rolled the change back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #1353.
The changes made to the
:graalvm-native-image-appGradle project were not included, neither were the API documentation changes made toMongoClientSettings, the rest of the changes was taken as is.JAVA-5390