Refactor transaction server pinning #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Determine whether TransactionContext is required based on ConnectionSource's ServerDescription instead of the ClusterDescription. JAVA-5186
After the previous refactoring, this method is only used by tests, so it can be removed. JAVA-5186
jyemin
commented
Oct 2, 2023
driver-sync/src/main/com/mongodb/client/internal/ClientSessionBinding.java
Show resolved
Hide resolved
jyemin
commented
Oct 2, 2023
...ctive-streams/src/main/com/mongodb/reactivestreams/client/internal/ClientSessionBinding.java
Outdated
Show resolved
Hide resolved
stIncMale
requested changes
Oct 3, 2023
driver-core/src/test/functional/com/mongodb/ClusterFixture.java
Outdated
Show resolved
Hide resolved
driver-core/src/test/functional/com/mongodb/ClusterFixture.java
Outdated
Show resolved
Hide resolved
...ctive-streams/src/main/com/mongodb/reactivestreams/client/internal/ClientSessionBinding.java
Outdated
Show resolved
Hide resolved
...ctive-streams/src/main/com/mongodb/reactivestreams/client/internal/ClientSessionBinding.java
Outdated
Show resolved
Hide resolved
...ctive-streams/src/main/com/mongodb/reactivestreams/client/internal/ClientSessionBinding.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Valentin Kovalenko <[email protected]>
stIncMale
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TransactionContextis required based onConnectionSource'sServerDescriptioninstead of the
ClusterDescriptionobtained fromCluster#getDescription.Cluster#getDescriptionis only used by tests, so it can be removed.JAVA-5186