Improve Time-Series Bucketing Scalability #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce customizable bucketMaxSpanSeconds and bucketRoundingSeconds options for Time-Series collections, providing users with more control over bucketing behaviors. These options allow for setting the maximum time difference between timestamps within a bucket and adjusting the rounding precision. Enhancing flexibility in managing Time-Series data. JAVA-4888
JAVA-4888
JAVA-4888
vbabanin
commented
Jun 6, 2023
| * @mongodb.driver.manual core/timeseries-collections/ Time-series collections | ||
| * @see #getBucketMaxSpan(TimeUnit) | ||
| */ | ||
| public TimeSeriesOptions bucketMaxSpan(@Nullable final Long bucketMaxSpan, final TimeUnit timeUnit) { |
There was a problem hiding this comment.
As for now, TimeUnit is used in order to maintain consistency within the driver since this approach ensures a unified way of handling time intervals throughout the codebase.
There is a task JAVA-4191 for introducing Duration for the API, which will enhance the functionality further
rozza
requested changes
Jun 7, 2023
| * </p> | ||
| * | ||
| * @param bucketMaxSpan time span between measurements. After conversion to seconds using {@link TimeUnit#convert(long, java.util.concurrent.TimeUnit)}, | ||
| * the value must be >= 1. |
There was a problem hiding this comment.
Nit: Also accepts null so add something to say a null value will unset any previously set value.
| * Returns the maximum time span between measurements in a bucket. | ||
| * | ||
| * @param timeUnit the time unit. | ||
| * @return time span between measurements. |
stIncMale
requested changes
Jun 12, 2023
driver-core/src/main/com/mongodb/client/model/TimeSeriesOptions.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/client/model/TimeSeriesOptions.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/client/model/TimeSeriesOptions.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/client/model/TimeSeriesOptions.java
Outdated
Show resolved
Hide resolved
driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedCrudHelper.java
Show resolved
Hide resolved
stIncMale
reviewed
Jun 12, 2023
- Add tests. - Lower server version because bucket options were backported to 6.3 JAVA-4888
JAVA-4888
stIncMale
requested changes
Jun 14, 2023
driver-core/src/test/functional/com/mongodb/client/model/TimeSeriesOptionsTest.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/client/model/TimeSeriesOptions.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/client/model/TimeSeriesOptions.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/client/model/TimeSeriesOptions.java
Outdated
Show resolved
Hide resolved
JAVA-4888
stIncMale
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces new options,
bucketMaxSpanSecondsandbucketRoundingSecondsto provide the flexibility of bucketing in time-series collections, enabling users to customize bucket boundaries and rounding behavior.Users can directly set bucketMaxSpanSeconds and bucketRoundingSeconds, ensuring they are equal.
Existing granularity settings remain supported.
JAVA-4888