Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GODRIVER-1962 unwrap errors in WithTransaction #634

Merged
merged 4 commits into from
Apr 23, 2021

Conversation

iwysiu
Copy link
Contributor

@iwysiu iwysiu commented Apr 14, 2021

No description provided.

Copy link
Contributor

@benjirewis benjirewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a question.

mongo/session.go Outdated Show resolved Hide resolved
mongo/session.go Outdated Show resolved Hide resolved
mongo/session.go Outdated Show resolved Hide resolved
@iwysiu iwysiu requested a review from divjotarora April 22, 2021 19:47
Copy link
Contributor

@divjotarora divjotarora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits, but LGTM.

mongo/with_transactions_test.go Outdated Show resolved Hide resolved
mongo/with_transactions_test.go Show resolved Hide resolved
@iwysiu iwysiu merged commit 9a3bd05 into mongodb:master Apr 23, 2021
tsedgwick pushed a commit to mongodb-forks/mongo-go-driver that referenced this pull request May 27, 2021
tsedgwick pushed a commit to mongodb-forks/mongo-go-driver that referenced this pull request Jun 1, 2021
faem pushed a commit to kubedb/mongo-go-driver that referenced this pull request Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants