GODRIVER-1852 Add commitTransaction error check for timeout #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjirewis
commented
Jan 29, 2021
kevinAlbs
reviewed
Jan 29, 2021
benjirewis
commented
Jan 29, 2021
kevinAlbs
reviewed
Feb 1, 2021
iwysiu
approved these changes
Feb 1, 2021
divjotarora
reviewed
Feb 19, 2021
divjotarora
reviewed
Feb 22, 2021
divjotarora
reviewed
Feb 24, 2021
There was a problem hiding this comment.
Code changes LGTM. Just one additional note about leaving a comment to clarify what the code is doing for future readers. Additionally, can you rebase this branch on master and force-push? I see some test failures related to connection pooling and Atlas Data Lake, but these should be fixed by some of our recent commits. Once that's addressed, I can come back and approve.
added 8 commits
February 25, 2021 13:41
divjotarora
approved these changes
Feb 26, 2021
This was referenced Mar 14, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Closed
Merged
Closed
faem
pushed a commit
to kubedb/mongo-go-driver
that referenced
this pull request
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-1852
Adds a check for network timeout after executing the operation within a commitTransaction. Avoids incorrectly updating transaction state to "Committed" in the case of a timeout.
Adds test to make sure a transaction can still be aborted after a timed-out commitTransaction.