GODRIVER-2057 Fix uri merging on options.ClientOptions (#689)

mongodb · Jun 29, 2021 · 6d6365b · 6d6365b
1 parent fcfd2a3
commit 6d6365b
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/mongo/options/clientoptions.go b/mongo/options/clientoptions.go
@@ -873,7 +873,12 @@ func MergeClientOptions(opts ...*ClientOptions) *ClientOptions {
 		if opt.err != nil {
 			c.err = opt.err
 		}
-
+		if opt.uri != "" {
+			c.uri = opt.uri
+		}
+		if opt.cs != nil {
+			c.cs = opt.cs
+		}
 	}
 
 	return c

diff --git a/mongo/options/clientoptions_test.go b/mongo/options/clientoptions_test.go
@@ -175,6 +175,16 @@ func TestClientOptions(t *testing.T) {
 				t.Errorf("Merged client options do not match. got %v; want %v", got.err.Error(), opt1.err.Error())
 			}
 		})
+
+		t.Run("MergeClientOptions/uri", func(t *testing.T) {
+			opt1, opt2 := Client(), Client()
+			opt1.uri = "Test URI"
+
+			got := MergeClientOptions(nil, opt1, opt2)
+			if got.uri != "Test URI" {
+				t.Errorf("Merged client options do not match. got %v; want %v", got.uri, opt1.uri)
+			}
+		})
 	})
 	t.Run("ApplyURI", func(t *testing.T) {
 		baseClient := func() *ClientOptions {