Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSHARP-5326: Mark API as obsolete: Guids #1495

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Conversation

papafe
Copy link
Contributor

@papafe papafe commented Oct 11, 2024

No description provided.

@papafe papafe requested a review from a team as a code owner October 11, 2024 08:06
@papafe papafe requested review from adelinowona and BorisDog and removed request for a team and adelinowona October 11, 2024 08:06
@papafe
Copy link
Contributor Author

papafe commented Oct 11, 2024

@BorisDog it seems that most of the things mentioned in the deprecation mentioned have already been done, so this is a very small PR

namespace MongoDB.Bson
{
/// <summary>
/// Whether to handle GuidRepresentation using the v2.x mode of the v3.x mode.
/// See the reference documentation for details.
/// </summary>
[Obsolete("This enum will be made removed in a later release, with V3 being the only representation mode.")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure that compilation succeeds before merging

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

Copy link
Contributor

@BorisDog BorisDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@papafe papafe changed the title CSHARP-5323: Mark API as obsolete: Guids CSHARP-5326: Mark API as obsolete: Guids Oct 14, 2024
@papafe papafe merged commit 0bf1089 into mongodb:v2.x Oct 14, 2024
@papafe papafe deleted the csharp5326 branch October 14, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants