-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CDRIVER-4497 CTest Test Fixtures for MongoDB Servers #1112
Open
vector-of-bool
wants to merge
69
commits into
mongodb:master
Choose a base branch
from
vector-of-bool:mdb-server-test-fixtures
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
CDRIVER-4497 CTest Test Fixtures for MongoDB Servers #1112
vector-of-bool
wants to merge
69
commits into
mongodb:master
from
vector-of-bool:mdb-server-test-fixtures
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… back to the command builder
…e-out-exec-on-secondaries
… server test fixture
…rver-test-fixtures
kevinAlbs
changed the title
CTest Test Fixtures for MongoDB Servers
CDRIVER-4497 CTest Test Fixtures for MongoDB Servers
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer: CXX-2303 (this work can be applied to both the C and C++ driver projects, if desired).
This is a changeset that has been a long time in the works (first experimenting in November of 2021). It has been used and developed along with several other changes over the time frame, so the commit log will contain WIP-commits and merges of unrelated tasks from months prior. In short: The commit log is very not helpful here.
Instead, here's an ordered outline of the change and how one might go about understanding them:
Refer: CTest test fixtures. CTest gained the ability to run and order tests that represent the setup and cleanup of arbitrary test fixtures. A test may declare a
FIXTURES_REQUIRED
on one or more fixtures. A test may also declareFIXTURES_SETUP
to inform CTest about the fixtures that it will "setup." Finally, a test may declare aFIXTURES_CLEANUP
to tell CTest about which fixtures it will "clean up".For any fixture
F
, CTest will ensure that theSETUP
"tests" ofF
are executed before every test thatREQUIRES
it. After all of its dependents are finished, CTest will execute theCLEANUP
"tests" forF
. Fixtures are scoped to the entire CTest run: The fixture will be set up once before its dependents run, and it will be torn down once after its dependents have finished. Fixture setup/cleanup "tests" can also depend on other fixtures. This creates a DAG of fixtures.Refer:
build/proc_ctl.py
- This is a zero-deps Python script that implements very rudimentary long-running process control. This was added in IMDS Mock Server Testing #1108 and further updated in this PR. A child process is associated with a "control directory" whereproc_ctl
will write files to communicate with itself through time. When we "start" withproc_ctl
, it will execute a child Python process that acts as a monitor. This monitor then spawns the actual child process. The monitor is left running while the top-levelproc_ctl
finishes. When the monitor process detects the child's exit, it will write information about that exit into the control directory. When we "stop" withproc_ctl
, we send aSIGINT
(or equivalent) to the child process. If it is well-behaved, it will shutdown. We spin until we see the child process exit.Refer:
mdb-ctl.py
- This is a zero-deps Python script that wrapsproc_ctl
and provides utility commands to control a MongoDB server process. This is similar tomlaunch
, but zero-deps and more tooling-friendly. This is the script that is invoked by CTest fixtures to start/stop/setup servers. This script expects to be given a filepath to amongod
executable: It does not runmongod
from the PATH. In the future, if we can reliably obtainmlaunch
, it may be better to prefer it as a more well-tested tool.Refer: TestSuite and test
.c
files - A new parameter has been added to tests: "Meta". This is simply a string that will later be used byLoadTests.cmake
to instrument tests with fixtures and labels. All tests that use a live MongoDB server (not a mock) have theUSES_LIVE_SERVER
meta-argument. TheLABELS
meta-argument is also supported, and generates labels on the associated tests. Tests can be selected/excluded based on their label in a CTest run with-L
and-LE
.For example, to run all tests that do not require spinning up a live server, pass
-LE uses-live-server
to the CTest command.Since "meta" gives us introspection into which tests use external resources, test parallelism is now possible. Passing
-j <Number>
to CTest will run<Number>
tests in parallel, with a mutex on each of the live server fixtures (This "mutex" is created using theRESOURCE_LOCK
CMake test property). Each server fixture has its own "mutex", so multiple server fixtures can be run simultaneously and their dependent tests run in parallel without contending.Refer:
build/cmake/QuickFixtures.cmake
- This is a small CMake convenience module that allows concise definitions of CTest fixtures.Refer:
build/cmake/FindMongoDB.cmake
- This CMake module scans formongod
executables on PATH and installed using m. For each found executable, it detects the version and sets CMake properties about them for later use.This module also defines three functions that are the main purpose of this PR:
mongodb_create_fixture()
- Create a test fixture that runs amongod
server.mongodb_create_replset_fixture()
- Create a test fixture that spawns a replica set.mongodb_create_sharded_fixture()
- Create a test fixture that generates a very simple sharded cluster.This function records data about any created fixtures in a file
MongoDB-CTestData.cmake
, which is a script that will be loaded by CTest as part of test discovery. A particular fixture may be declared as "DEFAULT
", which will be used later byLoadTests.cmake
. TCP ports are allocated automatically for all servers that need to be spawned.Refer:
build/cmake/LoadTests.cmake
- This file is included by CTest to discover test cases. It uses the "meta" data on each test to decide how to register each test.For every test
T
marked withUSES_LIVE_SERVER
, and for each MongoDB fixtureF
that was marked withDEFAULT
, define a testT@F
. This test will be marked as a dependent ofF
. The URL to the server associated withF
will be injected into the test environment variables forT@F
, allowing the test to communicate with the server fixture that it depends on.Test execution: When CTest runs, if any test that requires a live server is selected (by default all tests are selected), the associated fixture will be marked for execution. Before running any test that requires the server, CTest will run the "setup" command for that server, which wipes the scratch data directory of the server and spawns a new server process. After all tests that require a particular fixture are finished, the server process will be stopped.
For replicaset fixtures, multiple servers may be spawned. The first server in the replicaset will be forced to be primary. The CTest "setup" of a replicaset will not "finish" until the server reports that it has been elected as the primary. This can take a few seconds. This is required by tests that need to performs writes, as the port of the first server will be given as the port of the server fixture for the test. Currently, there is no functionality for tests to depend on secondaries, but this would not be difficult to add.
For sharded cluster fixtures,
config
anddata
replica sets will be created, and an instance ofmongos
will be run against those two replicasets. The TCP port ofmongos
will be used as the TCP port given to the test.Defining fixtures: By default, no server fixtures are defined. The file
build/cmake/TweakMeServerFixtures.cmake
is intended to define the fixtures for the current configuration. This file can be filled out manually or written as part of CI to define the test set. If no default server fixtures are defined, the tests that require them will be generated with placeholders marked asDISABLED
. Note:LoadTests
defines a lot of tests, and having many fixtures will generate a huge number of tests. While this is good in general, this will impact the startup time of CTest, which will need to generate thousands of test cases.