Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-42020: queues feedback 5.0 #3222

Merged
merged 4 commits into from
Dec 2, 2024

Conversation

rustagir
Copy link
Contributor

@rustagir rustagir commented Nov 25, 2024

https://jira.mongodb.org/browse/DOCSP-42020

Replaces collection() with table()
Adds sentence about using default failed jobs provider from Laravel

Staging

Checklist

  • Add tests and ensure they pass

@rustagir rustagir requested a review from a team as a code owner November 25, 2024 15:33
@rustagir rustagir requested a review from norareidy November 25, 2024 15:33
@github-actions github-actions bot added the docs label Nov 25, 2024
Copy link
Contributor

@jordan-smith721 jordan-smith721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1 fix

docs/queues.txt Outdated Show resolved Hide resolved
@rustagir rustagir requested a review from GromNaN November 25, 2024 17:09
@@ -69,7 +79,7 @@ collection:
'failed' => [
'driver' => 'mongodb',
'database' => 'mongodb',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace connection with database in the table.

@@ -124,7 +133,7 @@ application's ``config/queue.php`` file:
'batching' => [
'driver' => 'mongodb',
'database' => 'mongodb',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also for job batching, replace connection with database.

@rustagir rustagir enabled auto-merge (squash) December 2, 2024 15:05
@rustagir rustagir mentioned this pull request Dec 2, 2024
@rustagir rustagir merged commit bd9c0a8 into mongodb:5.0 Dec 2, 2024
27 checks passed
This was referenced Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants