Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-43806: getColumns id alias #3165

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Conversation

rustagir
Copy link
Contributor

@rustagir rustagir commented Sep 30, 2024

Documents #3160
https://jira.mongodb.org/browse/DOCSP-43806

Staging

Checklist

  • Add tests and ensure they pass
  • Add an entry to the CHANGELOG.md file

@rustagir rustagir requested a review from a team as a code owner September 30, 2024 15:44
@github-actions github-actions bot added the docs label Sep 30, 2024
Copy link
Collaborator

@mcmorisi mcmorisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

data rather than the database schema. If the specified collection doesn't exist
or is empty, these methods return a value of ``false``.
Starting in {+odm-long+} v5.1, the ``getColumns()`` method returns
the ``_id`` field name as the alias ``id``. You can pass either
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence is not very clear for me. We need to tell the name "id" in the code correspond to the name "_id" in the database.

@rustagir rustagir merged commit 5c7e240 into mongodb:5.x Oct 1, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants