Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPORM-160 Add tests to documentation examples #2775

Merged
merged 1 commit into from
Mar 26, 2024
Merged

PHPORM-160 Add tests to documentation examples #2775

merged 1 commit into from
Mar 26, 2024

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Mar 14, 2024 •
edited
Loading

Fix PHPORM-160
Based on #2747

To run the test:

php vendor/bin/phpunit docs/includes/eloquent-models/relationships/RelationshipsExamplesTest.php

Preview: https://preview-mongodbcchomongodb.gatsbyjs.io/laravel/GromNaN-PHPORM-160/eloquent-models/

Checklist

  • Add tests and ensure they pass
  • Add an entry to the CHANGELOG.md file
  • Update documentation for new features

@GromNaN GromNaN added this to the 4.1 milestone Mar 14, 2024
@GromNaN GromNaN requested a review from a team as a code owner March 14, 2024 16:45
@GromNaN GromNaN requested a review from alcaeus March 14, 2024 16:45
@GromNaN GromNaN changed the base branch from 4.2 to 4.1 March 14, 2024 16:45
alcaeus
alcaeus requested changes Mar 15, 2024
View reviewed changes
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I focused my review on the DocumentationExamplesTest file. As for the rest of the commits, are those backports from a newer version? If so, can we backport a squashed commit? Also, is 4.1 the correct target branch here?

tests/DocumentationExamplesTest.php Outdated Show resolved Hide resolved
tests/DocumentationExamplesTest.php Outdated Show resolved Hide resolved
@GromNaN GromNaN requested a review from ccho-mongodb March 15, 2024 09:52
alcaeus
alcaeus approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests LGTM. I'll defer to the docs team to ensure the examples are what they expect.

@GromNaN GromNaN mentioned this pull request Mar 25, 2024
Merged
3 tasks
@GromNaN GromNaN added the docs label Mar 25, 2024
@GromNaN GromNaN changed the base branch from 4.1 to docs-rewrite March 25, 2024 16:26
@GromNaN GromNaN changed the base branch from docs-rewrite to 4.1 March 25, 2024 16:59
@GromNaN GromNaN requested a review from jmikola March 25, 2024 21:44
ccho-mongodb
ccho-mongodb approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@ccho-mongodb ccho-mongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GromNaN GromNaN merged commit 260620e into mongodb:4.1 Mar 26, 2024
15 checks passed
@GromNaN GromNaN deleted the PHPORM-160 branch March 26, 2024 15:06
@mongodb-php-bot mongodb-php-bot mentioned this pull request Mar 26, 2024
Merged
@GromNaN GromNaN mentioned this pull request Mar 26, 2024
Merged
@mongodb-php-bot mongodb-php-bot mentioned this pull request Mar 27, 2024
Merged
jmikola pushed a commit that referenced this pull request Mar 27, 2024
@GromNaN @jmikola
Add tests to doc examples (#2775)
90ebf12
This was referenced Apr 3, 2024
Closed
Closed
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccho-mongodb ccho-mongodb ccho-mongodb approved these changes

@alcaeus alcaeus alcaeus approved these changes

@jmikola jmikola Awaiting requested review from jmikola

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@GromNaN @alcaeus @ccho-mongodb