DOCSP-35970: Find one usage example #2768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustagir
requested changes
Mar 14, 2024
docs/usage-examples/findOne.txt
Outdated
Comment on lines
13
to
14
| :term:`natural order` in the database or according to the sort order specified by the | ||
| ``orderBy()`` method. |
There was a problem hiding this comment.
Suggested change
| :term:`natural order` in the database or according to the sort order specified by the | |
| ``orderBy()`` method. | |
| :term:`natural order` in the database or according to the sort order that you can specify by using the | |
| ``orderBy()`` method. |
3 tasks
rustagir
previously approved these changes
Mar 15, 2024
docs/usage-examples/findOne.txt
Outdated
| You can retrieve a single document from a collection by chaining the ``where()`` and | ||
| ``first()`` methods on an Eloquent model or a query builder. | ||
|
|
||
| Pass a query filter to the ``where()`` method and call the ``first()`` method to return |
There was a problem hiding this comment.
Suggested change
| Pass a query filter to the ``where()`` method and call the ``first()`` method to return | |
| Pass a query filter to the ``where()`` method and then call the ``first()`` method to return |
docs/usage-examples/findOne.txt
Outdated
Comment on lines
27
to
28
| - Defines a query filter that matches documents in which the value of the ``directors`` field | ||
| is ``"Rob Reiner"`` |
There was a problem hiding this comment.
S: I think the directors field is an array-valued field
Suggested change
| - Defines a query filter that matches documents in which the value of the ``directors`` field | |
| is ``"Rob Reiner"`` | |
| - Defines a query filter that matches documents in which the value of the ``directors`` field | |
| includes ``"Rob Reiner"`` |
docs/usage-examples/findOne.txt
Outdated
Comment on lines
46
to
58
| class MovieController | ||
| { | ||
| public function show() | ||
| { | ||
| $movie = Movie::where('directors', 'Rob Reiner') | ||
| ->orderBy('_id') | ||
| ->first(); | ||
|
|
||
| return view('browse_movies', [ | ||
| 'movie' => $movie | ||
| ]); | ||
| } | ||
| } |
There was a problem hiding this comment.
S: move into files and include (applies to all code examples)
norareidy
commented
Mar 26, 2024
…avel-mongodb into DOCSP-35970-find-one-usage
GromNaN
reviewed
Mar 26, 2024
| ->orderBy('_id') | ||
| ->first(); | ||
|
|
||
| print_r($movie->toJson()); |
There was a problem hiding this comment.
Do we really want to display the results with print_r? That is not very compatible with PHPUnit.
There was a problem hiding this comment.
How would you prefer to display the results? Originally I used a view, but I changed it to print_r for simplicity
There was a problem hiding this comment.
Since it's a simple string, I modified to use echo.
…avel-mongodb into DOCSP-35970-find-one-usage
GromNaN
reviewed
Apr 2, 2024
| ->orderBy('_id') | ||
| ->first(); | ||
|
|
||
| print_r($movie->toJson()); |
There was a problem hiding this comment.
Since it's a simple string, I modified to use echo.
|
|
||
| $this->assertInstanceOf(Movie::class, $movie); | ||
|
|
||
| $this->expectOutputRegex('^{"_id":"[a-z0-9]{24}","title":"The Shawshank Redemption","directors":["Frank Darabont","Rob Reiner"]}$'); |
GromNaN
force-pushed
the
DOCSP-35970-find-one-usage
branch
from
aad93f7 to
bf98e98
Compare
This was referenced Apr 4, 2024
Closed
Merged
Closed
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA - https://jira.mongodb.org/browse/DOCSP-35970
Staging - https://preview-mongodbnorareidy.gatsbyjs.io/laravel/DOCSP-35970-staging/usage-examples/findOne/
Checklist