Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-37601: university course link fix #2761

Conversation

ccho-mongodb
Copy link
Contributor

@ccho-mongodb ccho-mongodb commented Mar 11, 2024

JIRA: https://jira.mongodb.org/browse/DOCSP-37601
Staging: https://preview-mongodbcchomongodb.gatsbyjs.io/laravel/DOCSP-37601-fix-university-course-link/quick-start/

Also added a link to the release notes.

Checklist

  • Add tests and ensure they pass
  • Add an entry to the CHANGELOG.md file
  • Update documentation for new features

GromNaN
GromNaN previously approved these changes Mar 11, 2024
Chris Cho added 2 commits March 11, 2024 17:11
…cho-mongodb/laravel-mongodb into DOCSP-37601-university-course-link-fix
@ccho-mongodb ccho-mongodb requested a review from GromNaN March 11, 2024 21:20
@ccho-mongodb ccho-mongodb marked this pull request as ready for review March 11, 2024 21:20
@ccho-mongodb ccho-mongodb requested a review from a team as a code owner March 11, 2024 21:20
@ccho-mongodb
Copy link
Contributor Author

I'm having some trouble determining why it includes another commit (not mine) even though I had reset my local branch to the mongodb/laravel-mongodb remote using git reset --hard upstream/master prior to creating my branch. I'll recreate this PR to try to fix it.

@GromNaN
Copy link
Member

GromNaN commented Mar 12, 2024

The coding style fix is automatically applied by GitHub Action. #2765

@ccho-mongodb
Copy link
Contributor Author

The coding style fix is automatically applied by GitHub Action. #2765

Thanks -- it seemed strange because those were files that weren't part of my PR. Sorry for opening and closing all the PRs for this change. The final PR is here: #2764

@GromNaN GromNaN added the docs label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants