Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCSP-35964 eloquent models standardization #2726

Merged
merged 25 commits into from
Mar 25, 2024
Merged

DOCSP-35964 eloquent models standardization #2726

merged 25 commits into from
Mar 25, 2024

Conversation

ccho-mongodb
Copy link
Contributor

@ccho-mongodb ccho-mongodb commented Feb 12, 2024 •
edited
Loading

JIRA: https://jira.mongodb.org/browse/DOCSP-35964

Staging:
Eloquent Models Landing Page
Eloquent Models: Model Class Page

Note:
Most of the code snippets are untested. Will work on testing them prior to the technical review.

Converted to draft until these sections are completed

Do not merge until the other two sections, which correspond to the following tickets, are ready to merge:
https://jira.mongodb.org/browse/DOCSP-37056
https://jira.mongodb.org/browse/DOCSP-37057

Checklist

  • Add tests and ensure they pass
  • Add an entry to the CHANGELOG.md file
  • Update documentation for new features

@GromNaN GromNaN added the docs label Feb 13, 2024
@GromNaN GromNaN self-requested a review February 14, 2024 16:51
GromNaN
GromNaN reviewed Feb 14, 2024
View reviewed changes
docs/eloquent-models/relationships.txt Outdated Show resolved Hide resolved
docs/eloquent-models/model-class.txt Outdated Show resolved Hide resolved
GromNaN
GromNaN reviewed Feb 14, 2024
View reviewed changes
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This split seems correct to me.

docs/eloquent-models/schema-builder.txt Outdated Show resolved Hide resolved
@GromNaN
Copy link
Member

GromNaN commented Feb 22, 2024 •
edited
Loading

@ccho-mongodb I added coding style rules for the *.php files in the docs dir, and applied the changes that have been detected. I let you resolve the threads.

You can run vendor/bin/phpcs and vendor/bin/phpcbf locally to find and fix the issues when you make changes.

rachel-mack
rachel-mack previously approved these changes Feb 22, 2024
View reviewed changes
Copy link

@rachel-mack rachel-mack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few tweaks:

docs/eloquent-models/model-class.txt Outdated Show resolved Hide resolved
docs/eloquent-models/model-class.txt Outdated Show resolved Hide resolved
docs/includes/eloquent-models/PlanetMassPrune.php Outdated Show resolved Hide resolved
docs/eloquent-models/model-class.txt Show resolved Hide resolved
@ccho-mongodb ccho-mongodb marked this pull request as ready for review February 22, 2024 21:36
@ccho-mongodb ccho-mongodb requested a review from GromNaN February 22, 2024 21:36
GromNaN
GromNaN requested changes Feb 23, 2024
View reviewed changes
docs/eloquent-models/model-class.txt Outdated Show resolved Hide resolved
docs/eloquent-models/model-class.txt Outdated Show resolved Hide resolved
docs/eloquent-models/model-class.txt Show resolved Hide resolved
docs/eloquent-models/model-class.txt Outdated Show resolved Hide resolved
docs/eloquent-models/model-class.txt Outdated Show resolved Hide resolved
docs/eloquent-models/model-class.txt Outdated Show resolved Hide resolved
docs/eloquent-models/model-class.txt Outdated Show resolved Hide resolved
@ccho-mongodb ccho-mongodb requested a review from GromNaN February 26, 2024 15:17
GromNaN
GromNaN approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/eloquent-models/model-class.txt Outdated Show resolved Hide resolved
@ccho-mongodb ccho-mongodb requested a review from a team as a code owner February 28, 2024 16:24
@ccho-mongodb ccho-mongodb marked this pull request as draft February 28, 2024 16:32
@GromNaN GromNaN changed the base branch from 4.1 to docs-rewrite March 25, 2024 16:26
@GromNaN GromNaN changed the base branch from docs-rewrite to 4.1 March 25, 2024 16:51
@ccho-mongodb ccho-mongodb marked this pull request as ready for review March 25, 2024 20:57
@ccho-mongodb ccho-mongodb merged commit 434d1b8 into mongodb:4.1 Mar 25, 2024
15 checks passed
@ccho-mongodb ccho-mongodb deleted the DOCSP-35964-eloquent-models-standardization branch March 25, 2024 21:01
This was referenced Mar 25, 2024
Closed
Closed
Merged
Merged
jmikola pushed a commit that referenced this pull request Mar 27, 2024
@jmikola
DOCSP-35964 eloquent models standardization (#2726)
76c7f4e 
* DOCSP-35964: Eloquent Models section
This was referenced Apr 3, 2024
Closed
Closed
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GromNaN GromNaN GromNaN approved these changes

@rachel-mack rachel-mack rachel-mack left review comments

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ccho-mongodb @GromNaN @rachel-mack