[Fix] morphTo relationship #2669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 54c9a85
hans-thomas
commented
Nov 6, 2023
GromNaN
reviewed
Nov 7, 2023
alcaeus
approved these changes
Nov 8, 2023
|
Thank you @hans-thomas! |
jmikola
reviewed
Jun 19, 2024
| @@ -221,7 +221,7 @@ public function morphTo($name = null, $type = null, $id = null, $ownerKey = null | |||
| $this->newQuery(), | |||
| $this, | |||
| $id, | |||
| $ownerKey, | |||
| $ownerKey ?: $this->getKeyName(), | |||
| @@ -16,7 +16,11 @@ public function addConstraints() | |||
| // For belongs to relationships, which are essentially the inverse of has one | |||
| // or has many relationships, we need to actually query on the primary key | |||
| // of the related models matching on the foreign key that's on a parent. | |||
| $this->query->where($this->ownerKey, '=', $this->parent->{$this->foreignKey}); | |||
| $this->query->where( | |||
| $this->ownerKey, | |||
There was a problem hiding this comment.
Removing the $this->getKeyName() fallback in HybridRelations::morphTo and allowing MorphTo to be constructed with a null $ownerKey would result in an exception here when null is used in place of a string field name.
The relevant fix in #3011 is to fall back to $this->getForeignKeyName() here, which respects a custom primary key name on parent.
|
|
||
| // inverse | ||
| $photo = Photo::query()->create(['url' => 'https://graph.facebook.com/hans.thomas/picture']); | ||
| $client = Client::create(['name' => 'Hans Thomas']); |
There was a problem hiding this comment.
@hans-thomas: Was there a particular reason you used Photo::query()->create() above but Client::create() here? Best I could tell, they resolve to the same Builder::create() method.
Client::create() just ends up forwarding the call through Model::__call().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, it fixes #2657.