Implement MassPrunable without chunks limit
#2598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
force-pushed
the
mass-prunable
branch
from
3769dd0 to
952cc3a
Compare
GromNaN
force-pushed
the
mass-prunable
branch
from
952cc3a to
2449aeb
Compare
GromNaN
commented
Sep 4, 2023
alcaeus
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2597
Custom implementation of
MassPrunableis required to prevent using the limit. #2591 added an exception when limited is used because MongoDB Delete operation doesn't support it.MassPrunable::pruneAll()is called by the commandmodel:prune.Prunable feature was introducted in Laravel 8.x by laravel/framework#37889.
Users have to be aware that MassPrunable can break relationships as it doesn't call model methods to remove links.