Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(NODE-4158): Annotate BSON classes with a category #496

Merged
merged 4 commits into from
Apr 20, 2022
Merged

Conversation

kampofo
Copy link
Contributor

@kampofo kampofo commented Apr 19, 2022

https://jira.mongodb.org/browse/NODE-4158

Description

What is changing?

Is there new documentation needed for these changes?

What is the motivation for this change?

Double check the following

  • Ran npm run lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

baileympearson
baileympearson previously approved these changes Apr 20, 2022
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First PR on the Node team! 🎉 🥳

@baileympearson baileympearson added the Team Review Needs review from team label Apr 20, 2022
@baileympearson
Copy link
Contributor

Screen Shot 2022-04-20 at 10 16 19 AM

BSON types now show up grouped by class

Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit :) nice work!

src/map.ts Outdated Show resolved Hide resolved
@kampofo kampofo merged commit cadd628 into main Apr 20, 2022
@kampofo kampofo deleted the NODE-4158 branch April 20, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants