Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed AKO Roles for multiple namespaces #353

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Fixed AKO Roles for multiple namespaces #353

merged 1 commit into from
Oct 29, 2024

Conversation

igor-karpukhin
Copy link
Collaborator

All Submissions:

Fixed an error when Helm couldn't render RBAC permissions for Atlas Operator Roles

  • Have you opened an Issue before filing this PR?
  • Have you signed our CLA?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

josvazg
josvazg reviewed Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@josvazg josvazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let me run the e2e tests that were failing before

@igor-karpukhin igor-karpukhin merged commit 5ab115d into main Oct 29, 2024
5 checks passed
@igor-karpukhin igor-karpukhin deleted the fix/ako-rbac branch October 29, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josvazg josvazg josvazg approved these changes

@tibulca tibulca Awaiting requested review from tibulca tibulca is a code owner

@mircea-cosbuc mircea-cosbuc Awaiting requested review from mircea-cosbuc mircea-cosbuc is a code owner

@helderjs helderjs Awaiting requested review from helderjs helderjs is a code owner

@lsierant lsierant Awaiting requested review from lsierant lsierant is a code owner

@slaskawi slaskawi Awaiting requested review from slaskawi slaskawi is a code owner

@roothorp roothorp Awaiting requested review from roothorp roothorp is a code owner

@nammn nammn Awaiting requested review from nammn nammn is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igor-karpukhin @josvazg