Allow setting custom labels on mongo operator pod #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aistoica
requested review from
tibulca,
mircea-cosbuc,
igor-karpukhin,
helderjs,
lsierant,
slaskawi,
josvazg,
roothorp and
nammn
as code owners
|
closes #345 |
s-urbaniak
approved these changes
Aug 26, 2024
|
generally LGTM but setting up a proof PR against the AKO repository to verify that e2e succeeds. |
josvazg
approved these changes
Aug 26, 2024
igor-karpukhin
approved these changes
Aug 26, 2024
3 tasks
|
LGTM once mongodb/mongodb-atlas-kubernetes#1786 is green. Thank you for the contribution! |
|
This changed passed all e2e tests on the proof PR, merging 🎉 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if such).