-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add namespace override to community-operator #284
Open
bbergquist0930
wants to merge
13
commits into
mongodb:main
Choose a base branch
from
bbergquist0930:add_namespace_override_to_co
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add namespace override to community-operator #284
bbergquist0930
wants to merge
13
commits into
mongodb:main
from
bbergquist0930:add_namespace_override_to_co
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amespace-override' into 'cp-main' Resolve "Update community-operator chart to support having a namespace override" Closes mongodb#1 See merge request engineering/mgmt/3rdparty/mongodb-helm-charts!1
…de-is-configured' into 'cp-main' Resolve "Add conditional namespace template if namespaceOverride is configured" Closes mongodb#3 See merge request engineering/mgmt/3rdparty/mongodb-helm-charts!2
This adds a conditional template for the namespace specified as the operator override namespace.
…rator helm chart"
…ity-operator-helm-chart' into 'cp-main' Resolve "Add Gitlab CI support to build and publish the community-operator helm chart" Closes mongodb#2 See merge request engineering/mgmt/3rdparty/mongodb-helm-charts!3
…main' Resolve "Complete namespace support of the operator" Closes mongodb#4 See merge request engineering/mgmt/3rdparty/mongodb-helm-charts!4
…ency as community-operator-crds-cp"
…ency-as-community-operator-crds-cp' into 'cp-main' Draft: Resolve "Package community-operator-crds as local chart dependency as community-operator-crds-cp" Closes mongodb#5 See merge request engineering/mgmt/3rdparty/mongodb-helm-charts!5
bbergquist0930
requested review from
irajdeep,
tibulca,
mircea-cosbuc,
igor-karpukhin,
helderjs,
lsierant,
slaskawi,
josvazg,
roothorp and
nammn
as code owners
November 19, 2023 14:23
This PR is being marked stale because it has been open for 60 days with no activity. Please update the PR or ask for a fresh review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
closes #XXXX
in your comment to auto-close the issue that your PR fixes (if such).Closes #276
This allows the community-operator to be used as a subchart provided that #283 is merged in. This adds in a
_helpers.tpl
to help support the namespace override and creation. Also changes are made to set the Helm labels on the resources so that Helm knows about them. This is useful to support multiple instances of the community-operator chart in separate namespaces.This completes the namespace support of the operator. The operator should be able to be installed in the default namespace or in a custom namespace.
Usages
Install in the default chart namespace and the default Kubernetes namespace
Install in a custom chart namespace and the default Kubernetes namespace
Install in the default chart namespace and a custom Kubernetes namespace
Install in a custom chart namespace and a custom Kubernetes namespace